diff options
| author | Alex <git@ajschof.me> | 2024-08-20 00:30:19 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-08-20 00:30:19 +0100 |
| commit | efdd0d95a140a3bca04e63a4318c49271c6aa4e9 (patch) | |
| tree | 857506b9ec12952c966cae315c2baf4f8fb05aa4 /tests | |
| parent | fe2bd86c184ca04c382b6b1b2f71ed1207c2fd5b (diff) | |
| parent | 640b0685cd795c03b571b3ca26fc9030b86c4f99 (diff) | |
| download | de-project-bentley-efdd0d95a140a3bca04e63a4318c49271c6aa4e9.tar.gz de-project-bentley-efdd0d95a140a3bca04e63a4318c49271c6aa4e9.zip | |
Merge pull request #69 from ajschofield/alex/py-improvements
pr: alex's python improvements
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test_extract_lambda.py | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/tests/test_extract_lambda.py b/tests/test_extract_lambda.py index 3931cfc..3d15927 100644 --- a/tests/test_extract_lambda.py +++ b/tests/test_extract_lambda.py @@ -58,7 +58,7 @@ def s3_mock_bucket(s3_client): class TestLambdaHandler: - def test_lambda_handler_files_processed_and_uploaded_successfully(self, mocker): + def test_files_processed_and_uploaded_successfully(self, mocker): mock_db = MagicMock() mock_db.run.side_effect = [ [["Fruits"]], @@ -72,7 +72,11 @@ class TestLambdaHandler: ] with patch("src.extract_lambda.connect_to_database", return_value=mock_db): mock_process_and_upload_tables = mocker.patch( - "src.extract_lambda.process_and_upload_tables", return_value=mock_db + "src.extract_lambda.process_and_upload_tables", + return_value={ + "updated": ["Fruits"], + "no change": ["Vegetable", "Berry"], + }, ) mock_list_existing_s3_files = mocker.patch( "src.extract_lambda.list_existing_s3_files", return_value={} @@ -81,15 +85,15 @@ class TestLambdaHandler: context = {} response = lambda_handler(event, context) assert response["statusCode"] == 200 - assert ( - json.loads(response["body"]) - == "CSV files processed and uploaded successfully." + assert json.loads(response["body"]) == ( + "CSV files processed for Fruits and uploaded successfully." + "The following tables were not updated: Vegetable, Berry" ) mock_list_existing_s3_files.assert_called_once() mock_process_and_upload_tables.assert_called_once_with(mock_db, {}) mock_db.close.assert_called_once() - def test_lambda_handler_no_changes_detected_no_files_uploaded(self, mocker): + def test_no_changes_detected_no_files_uploaded(self, mocker): mock_db = MagicMock() mock_db.run.side_effect = [ [["Fruits"]], @@ -104,7 +108,8 @@ class TestLambdaHandler: with patch("src.extract_lambda.connect_to_database", return_value=mock_db): mock_process_and_upload_tables = mocker.patch( - "src.extract_lambda.process_and_upload_tables", return_value=False + "src.extract_lambda.process_and_upload_tables", + return_value={"updated": [], "no change": ["Fruits"]}, ) mock_list_existing_s3_files = mocker.patch( "src.extract_lambda.list_existing_s3_files", return_value={} @@ -121,7 +126,7 @@ class TestLambdaHandler: mock_process_and_upload_tables.assert_called_once_with(mock_db, {}) mock_db.close.assert_called_once() - def test_lambda_handler_exception_error(self, mocker): + def test_exception_error(self, mocker): with patch( "src.extract_lambda.connect_to_database", side_effect=Exception("Database connection error"), |