diff options
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/test_extract_lambda.py | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/tests/test_extract_lambda.py b/tests/test_extract_lambda.py index 5a1c5b2..347ef22 100644 --- a/tests/test_extract_lambda.py +++ b/tests/test_extract_lambda.py @@ -1,3 +1,5 @@ +import boto3.exceptions +import botocore.exceptions import pytest import boto3 from moto import mock_aws @@ -35,7 +37,7 @@ def mock_config(): def aws_credentials(): os.environ["AWS_ACCESS_KEY_ID"] = "testing" os.environ["AWS_SECRET_ACCESS_KEY"] = "testing" - os.environ["AWS_SECURIT_TOKEN"] = "testing" + os.environ["AWS_SECURITY_TOKEN"] = "testing" os.environ["AWS_SESSION_TOKEN"] = "testing" os.environ["AWS_DEFAULT_REGION"] = "eu-west-2" @@ -46,6 +48,15 @@ def s3_client(aws_credentials): yield boto3.client("s3") +@pytest.fixture(scope="class") +def s3_mock_bucket(s3_client): + bucket = s3_client.create_bucket( + Bucket="extract_bucket", + CreateBucketConfiguration={"LocationConstraint": "eu-west-2"}, + ) + return bucket + + class TestLambdaHandler: def test_lambda_handler_files_processed_and_uploaded_successfully(self, mocker): mock_db = MagicMock() @@ -138,27 +149,18 @@ class TestListExistingS3Files: list_existing_s3_files(client=s3_client) assert "Error listing S3 objects" in caplog.text - def test_error_if_bucket_is_empty(self, s3_client, caplog): - s3_client.create_bucket( - Bucket="extract_bucket", - CreateBucketConfiguration={"LocationConstraint": "eu-west-2"}, - ) + def test_error_if_bucket_is_empty(self, s3_client, caplog, s3_mock_bucket): list_existing_s3_files("extract_bucket", client=s3_client) assert "The bucket is empty" in caplog.text - def test_error_retrieving_object(self, s3_client, caplog): + def test_retrieves_file_content(self, s3_client, caplog, s3_mock_bucket): s3_client.upload_file("tests/dummy.txt", "extract_bucket", "dummy.txt") - list_existing_s3_files(bucket_name="test_bucket", client=s3_client) - - assert "Error retrieving S3 object " in caplog.text - - def test_retrieves_file_content(self, s3_client, caplog): - result = list_existing_s3_files(client=s3_client) - + result = list_existing_s3_files("extract_bucket", client=s3_client) assert list(result.values()) == ["This is a test file."] class TestConnectToDatabase: + # had mock_config in param def test_connect_to_database(mock_conn, mock_config): with patch("src.extract_lambda.Connection", autospec=True) as mock_conn: connect_to_database() @@ -166,7 +168,7 @@ class TestConnectToDatabase: host="abc", user="def", port="5432", password="password", database="db" ) - def test_database_error(self, mock_config): + def test_database_error(self, mock_config): # had mock_config in param with pytest.raises(DBConnectionException): connect_to_database() @@ -178,7 +180,6 @@ class TestConnectToDatabase: connect_to_database() assert "Interface error" in caplog.text - class TestProcessAndUploadTables: def test_error_process_and_upload_tables(mock_conn, s3_client, caplog): caplog.set_level(logging.INFO) @@ -218,4 +219,3 @@ class TestProcessAndUploadTables: # Assert that the log contains "No new data" assert "No new data" in caplog.text - # process and upload tables needs more tests |