From 09b8010a453c99164540981060177fdd2280df7e Mon Sep 17 00:00:00 2001
From: Alex Schofield <git@ajschof.me>
Date: Mon, 19 Aug 2024 21:41:31 +0100
Subject: infra(tf): remove repetitive suffix resources in events.tf

---
 terraform/events.tf | 26 +++++++-------------------
 1 file changed, 7 insertions(+), 19 deletions(-)

(limited to 'terraform/events.tf')

diff --git a/terraform/events.tf b/terraform/events.tf
index c2efbbc..832a965 100644
--- a/terraform/events.tf
+++ b/terraform/events.tf
@@ -2,19 +2,7 @@
 # Random String #
 #################
 
-resource "random_string" "eventbridge_suffix" {
-  length  = 8
-  special = false
-  upper   = false
-}
-
-resource "random_string" "s3_ingestion_suffix" {
-  length  = 8
-  special = false
-  upper   = false
-}
-
-resource "random_string" "s3_transform_suffix" {
+resource "random_string" "suffix" {
   length  = 8
   special = false
   upper   = false
@@ -38,14 +26,14 @@ resource "aws_cloudwatch_event_target" "extract_lambda_cw_event" {
 }
 
 resource "aws_lambda_permission" "allow_eventbridge" {
-  statement_id  = "AllowExecutionFromEventBridge${random_string.eventbridge_suffix.result}"
+  statement_id  = "AllowExecutionFromEventBridge${random_string.suffix.result}"
   action        = "lambda:InvokeFunction"
   function_name = aws_lambda_function.extract_lambda.function_name
   principal     = "events.amazonaws.com"
   source_arn    = aws_cloudwatch_event_rule.lambda_trigger.arn
 
   lifecycle {
-    replace_triggered_by = [random_string.eventbridge_suffix]
+    replace_triggered_by = [random_string.suffix]
   }
 }
 
@@ -54,14 +42,14 @@ resource "aws_lambda_permission" "allow_eventbridge" {
 ########################################
 
 resource "aws_lambda_permission" "allow_s3_ingestion" {
-  statement_id  = "AllowS3InvokeLambdaTransform${random_string.s3_ingestion_suffix.result}"
+  statement_id  = "AllowS3InvokeLambdaTransform${random_string.suffix.result}"
   action        = "lambda:InvokeFunction"
   function_name = aws_lambda_function.transform_lambda.function_name #replaced lambda name placeholder
   principal     = "s3.amazonaws.com"
   source_arn    = aws_s3_bucket.extract_bucket.arn #replaced bucket name placeholder
 
   lifecycle {
-    replace_triggered_by = [random_string.s3_ingestion_suffix]
+    replace_triggered_by = [random_string.suffix]
   }
 }
 
@@ -82,14 +70,14 @@ resource "aws_s3_bucket_notification" "extract_bucket_notification" {
 ##########################################
 
 resource "aws_lambda_permission" "allow_s3_transform_bucket" {
-  statement_id  = "AllowS3InvokeLambdaTransform${random_string.s3_transform_suffix.result}"
+  statement_id  = "AllowS3InvokeLambdaTransform${random_string.suffix.result}"
   action        = "lambda:InvokeFunction"
   function_name = aws_lambda_function.transform_lambda.function_name #replaced lambda name placeholder
   principal     = "s3.amazonaws.com"
   source_arn    = aws_s3_bucket.transform_bucket.arn #replaced bucket name placeholder
 
   lifecycle {
-    replace_triggered_by = [random_string.s3_transform_suffix]
+    replace_triggered_by = [random_string.suffix]
   }
 }
 
-- 
cgit v1.2.3