From e788a90307831d968fcac51dc5d70d356a5a5f63 Mon Sep 17 00:00:00 2001
From: lian-manonog <lian.manonog@gmail.com>
Date: Tue, 20 Aug 2024 12:05:56 +0100
Subject: Complete: completed testing for extract bucket - all passing

---
 tests/test_extract_lambda.py | 29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)

(limited to 'tests')

diff --git a/tests/test_extract_lambda.py b/tests/test_extract_lambda.py
index 3d15927..3cd2405 100644
--- a/tests/test_extract_lambda.py
+++ b/tests/test_extract_lambda.py
@@ -15,6 +15,7 @@ from src.extract_lambda import (
     lambda_handler,
     process_and_upload_tables,
     retrieve_secrets,
+    extract_bucket
 )
 
 
@@ -146,6 +147,31 @@ class TestLambdaHandler:
             mock_process_and_upload_tables.assert_not_called()
 
 
+class TestExtractBucket:
+    def test_extract_bucket_returns_bucket_name(self, s3_client, s3_mock_bucket):
+        result = extract_bucket(s3_client)
+        assert result == "extract_bucket"
+
+    def test_bucket_returns_first_bucket(self, s3_client):
+        bucket1 = s3_client.create_bucket(
+            Bucket='bucket1',
+            CreateBucketConfiguration={"LocationConstraint": "eu-west-2"},
+        )
+        result = extract_bucket(s3_client)
+        assert result == "extract_bucket"
+
+    def test_returns_index_error_if_no_buckets(self, s3_client):
+        s3_client.delete_bucket(
+            Bucket="extract_bucket"
+        )
+        s3_client.delete_bucket(
+            Bucket="bucket1"
+        )
+
+        with pytest.raises(IndexError, match="list index out of range"):
+            extract_bucket(s3_client)
+
+    
 class TestListExistingS3Files:
     def test_error_if_no_bucket(self, s3_client, caplog):
         logger = logging.getLogger()
@@ -165,7 +191,6 @@ class TestListExistingS3Files:
 
 
 class TestConnectToDatabase:
-    # had mock_config in param
     def test_connect_to_database(mock_conn, mock_config):
         with patch("src.extract_lambda.Connection", autospec=True) as mock_conn:
             connect_to_database()
@@ -187,7 +212,7 @@ class TestConnectToDatabase:
 
 
 class TestProcessAndUploadTables:
-    def test_error_process_and_upload_tables(mock_conn, s3_client, caplog):
+    def test_error_process_and_upload_tables(self, mock_conn, s3_client, caplog):
         caplog.set_level(logging.INFO)
 
         # Mock return values for database queries
-- 
cgit v1.2.3


From 0870dc49ddbd6024dddb289909487a15c26a3383 Mon Sep 17 00:00:00 2001
From: "deepsource-autofix[bot]"
 <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date: Tue, 20 Aug 2024 11:08:24 +0000
Subject: style: format code with Autopep8, Black and Ruff Formatter

This commit fixes the style issues introduced in e788a90 according to the output
from Autopep8, Black and Ruff Formatter.

Details: https://github.com/ajschofield/de-project-bentley/pull/72
---
 tests/test_extract_lambda.py | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

(limited to 'tests')

diff --git a/tests/test_extract_lambda.py b/tests/test_extract_lambda.py
index 3cd2405..548ce67 100644
--- a/tests/test_extract_lambda.py
+++ b/tests/test_extract_lambda.py
@@ -15,7 +15,7 @@ from src.extract_lambda import (
     lambda_handler,
     process_and_upload_tables,
     retrieve_secrets,
-    extract_bucket
+    extract_bucket,
 )
 
 
@@ -154,24 +154,20 @@ class TestExtractBucket:
 
     def test_bucket_returns_first_bucket(self, s3_client):
         bucket1 = s3_client.create_bucket(
-            Bucket='bucket1',
+            Bucket="bucket1",
             CreateBucketConfiguration={"LocationConstraint": "eu-west-2"},
         )
         result = extract_bucket(s3_client)
         assert result == "extract_bucket"
 
     def test_returns_index_error_if_no_buckets(self, s3_client):
-        s3_client.delete_bucket(
-            Bucket="extract_bucket"
-        )
-        s3_client.delete_bucket(
-            Bucket="bucket1"
-        )
+        s3_client.delete_bucket(Bucket="extract_bucket")
+        s3_client.delete_bucket(Bucket="bucket1")
 
         with pytest.raises(IndexError, match="list index out of range"):
             extract_bucket(s3_client)
 
-    
+
 class TestListExistingS3Files:
     def test_error_if_no_bucket(self, s3_client, caplog):
         logger = logging.getLogger()
-- 
cgit v1.2.3