From 3e89605d36793f16d35ae81b9ce5ffbc5c1bca2f Mon Sep 17 00:00:00 2001 From: Alex Schofield Date: Tue, 5 May 2026 22:22:12 +0100 Subject: improve error handling when fetching data --- fnme/data.py | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) (limited to 'fnme/data.py') diff --git a/fnme/data.py b/fnme/data.py index 6d85f43..9bb0f74 100644 --- a/fnme/data.py +++ b/fnme/data.py @@ -6,6 +6,7 @@ import requests from platformdirs import user_cache_path from fnme.constants import ENDPOINT, HEADERS +from fnme.exceptions import DataFetchError def get_latest_data() -> tuple[pd.DataFrame, str | None]: @@ -28,8 +29,12 @@ def get_latest_data() -> tuple[pd.DataFrame, str | None]: ), } - response = requests.get(ENDPOINT, headers=conditional_headers, timeout=10) - response.raise_for_status() + try: + response = requests.get( + ENDPOINT, headers=conditional_headers, timeout=10 + ) + except requests.RequestException as e: + raise DataFetchError(message=f"GET request failed: {e}") if response.status_code == 304: print(f"[*] Using cached data. Last modified: {cached_last_modified}") @@ -38,6 +43,14 @@ def get_latest_data() -> tuple[pd.DataFrame, str | None]: print("[!] Cache is stale. Refreshing.") last_modified = response.headers.get("Last-Modified") - csv_path.write_text(response.text, encoding="utf-8") - timestamp_path.write_text(last_modified or "") + + try: + csv_path.write_text(response.text, encoding="utf-8") + except Exception as e: + raise DataFetchError(message=f"Error writing CSV cache: {e}") + try: + timestamp_path.write_text(last_modified or "") + except Exception as e: + raise DataFetchError(message=f"Error writing timestamp file: {e}") + return pd.read_csv(csv_path), last_modified -- cgit v1.2.3