From f612f71ef5d09ce93526b4268173c612f06ae701 Mon Sep 17 00:00:00 2001 From: Alex Schofield Date: Mon, 17 Feb 2025 01:17:06 +0000 Subject: use list comprehension when returning output from read_local --- obfuscator/csv_reader.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'obfuscator') diff --git a/obfuscator/csv_reader.py b/obfuscator/csv_reader.py index 55fb892..3b4496b 100644 --- a/obfuscator/csv_reader.py +++ b/obfuscator/csv_reader.py @@ -5,25 +5,19 @@ from obfuscator.logger import get_logger logger = get_logger("CSVReader") - class CSVReader: @staticmethod def read_local(path) -> List[Dict[str, str]]: logger.debug(f"Reading local CSV from: {path}") - data = [] try: - with open(path, mode="r", encoding="utf-8") as file: - reader = csv.DictReader(file) - for row in reader: - data.append(dict(row)) + with open(path, mode="r", encoding="utf-8") as f: + reader = csv.DictReader(f) + return [dict(row) for row in reader] except FileNotFoundError: logger.error(f"File not found: {path}") except Exception as e: logger.error(f"Error reading file: {e}") - - logger.debug(f"Total rows read: {len(data)}") - return data @staticmethod def read_s3(path) -> List[Dict[str, str]]: -- cgit v1.2.3