diff options
| author | Alex Schofield <git@ajschof.me> | 2024-08-19 22:28:31 +0100 |
|---|---|---|
| committer | Alex Schofield <git@ajschof.me> | 2024-08-19 22:28:31 +0100 |
| commit | 84b3dea3833ae65d53a1007567ee19c31bf34ee3 (patch) | |
| tree | 33ae4374550d0ec2054c0db419f786a086049188 /src | |
| parent | 88e71818aaf1bf67e4d2807d22d8122b7bf184f1 (diff) | |
| download | de-project-bentley-84b3dea3833ae65d53a1007567ee19c31bf34ee3.tar.gz de-project-bentley-84b3dea3833ae65d53a1007567ee19c31bf34ee3.zip | |
refactor(retrieve_secrets): use aws recommended method for retrieving secrets
Diffstat (limited to 'src')
| -rw-r--r-- | src/extract_lambda.py | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/src/extract_lambda.py b/src/extract_lambda.py index 6f841b4..1df4c34 100644 --- a/src/extract_lambda.py +++ b/src/extract_lambda.py @@ -55,18 +55,21 @@ def lambda_handler(event, context): db.close() -def retrieve_secrets( - sm_client=boto3.client("secretsmanager"), secret_name="bentley-secrets" -): +def retrieve_secrets(): + secret_name = "bentley-secrets" + region_name = "eu-west-2" + + # Create a Secrets Manager client + session = boto3.session.Session() + client = session.client(service_name="secretsmanager", region_name=region_name) + try: - response = sm_client.get_secret_value(SecretId=secret_name) - if "SecretString" in response: - secret = json.loads(response["SecretString"]) - return secret + get_secret_value_response = client.get_secret_value(SecretId=secret_name) except ClientError as e: - logger.error(f"Could not retrieve secrets: {e}") raise e + return get_secret_value_response["SecretString"] + def connect_to_database() -> Connection: try: |
