removed duplicate functions

1 files changed, 69 insertions, 16 deletions

diff --git a/tests/test_fact_sales_order.py b/tests/test_fact_sales_order.py
index 82845d7..ca53faa 100644
--- a/tests/test_fact_sales_order.py
+++ b/tests/test_fact_sales_order.py
@@ -1,5 +1,6 @@
-from src.fact_sales_order import create_dim_design, create_dim_staff, create_dim_currency
+from src.dataframes import create_dim_design, create_dim_staff, create_dim_payment_type, create_dim_counterparty, create_dim_currency
 import pandas as pd
+from unittest.mock import patch
 
 class TestCreateDimDesign:
     def test_dim_design_returns_dataframe(self):
@@ -36,22 +37,74 @@ class TestCreateDimStaff:
         expected_d = {"staff_id": ["Hello", "Bye"], "first_name": ["Hello", "Bye"], "last_name": ["Hello", "Bye"], "department_name": ["Hello", "Bye"], "location": ["Hello", "Bye"], "email_address": ["Hello", "Bye"]}
         expected_df = pd.DataFrame(data=expected_d)
         expected_result = expected_df.copy()
-        assert result.equals(expected_result)     
+        assert result.equals(expected_result)  
 
-class TestCreateDimCurrency:
-    def test_dim_currency_returns_dataframe(self):
-        d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"]}
-        test_df = {"currency": pd.DataFrame(data=d)}
-        result = create_dim_currency(test_df)
-        assert isinstance(result, pd.DataFrame)  
-        
-    def test_dim_currency_returns_columns_and_values(self):
-        d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"]}
-        test_df = {"currency": pd.DataFrame(data=d)}
-        result = create_dim_currency(test_df)
-        expected_d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"], "currency_name": ["US Dollar", "Euro", "Pound"]}
+class TestCreatePaymentType:
+    def test_create_dim_payment_type_returns_correct_columns_and_values(self):
+        d = {"payment_type_id": ["Hello", "Bye"], "payment_type_name": ["Hello", "Bye"]}
+        test_df = {"payment_type": pd.DataFrame(data=d)}
+        result = create_dim_payment_type(test_df)
+        expected_columns = ["payment_type_id", "payment_type_name"]
+        expected_d = {"payment_type_id": ["Hello", "Bye"], "payment_type_name": ["Hello", "Bye"]}
         expected_df = pd.DataFrame(data=expected_d)
-        expected_result = expected_df.copy()
-        assert result.equals(expected_result)
+        assert isinstance(result, pd.DataFrame)
+        assert list(result.columns) == expected_columns
+        assert result.equals(expected_df)
+
+class TestCreateDimCounterparty:
+    def test_create_dim_counterparty_type_returns_correct_columns_and_values(self):
+        data_d = {"counterparty_id": ["Hello", "Bye"], 
+             "counterparty_legal_name": ["Hello", "Bye"], 
+             "counterparty_legal_address_line_1": ["Hello", "Bye"], 
+             }
+        data_a = {"address_id":
+                  "address",
+                  }
+        test_df = {"address": pd.DataFrame(data=data_a)}
+        test_df = {}
+        result = create_dim_counterparty(test_df)
+
+        expected_columns = ["counterparty_id", 
+             "counterparty_legal_name", 
+             "counterparty_legal_address_line_1", 
+             "counterparty_legal_address_line_2", 
+             "counterparty_legal_district",
+             "counterparty_legal_city",
+             "counterparty_legal_postal_code",
+             "counterparty_legal_postal_code", 
+             "counterparty_legal_phone_number"]
+        expected_d = {"counterparty_id": ["Hello", "Bye"], 
+             "counterparty_legal_name": ["Hello", "Bye"], 
+             "counterparty_legal_address_line_1": ["Hello", "Bye"], 
+             "counterparty_legal_address_line_2": ["Hello", "Bye"], 
+             "counterparty_legal_district": ["Hello", "Bye"],
+             "counterparty_legal_city": ["Hello", "Bye"],
+             "counterparty_legal_postal_code": ["Hello", "Bye"],
+             "counterparty_legal_postal_code": ["Hello", "Bye"], 
+             "counterparty_legal_phone_number": ["Hello", "Bye"]}
+        expected_df = pd.DataFrame(data=expected_d)
+        assert isinstance(result, pd.DataFrame)
+        assert list(result.columns) == expected_columns
+        assert result.equals(expected_df)
+
+# # figuring out how to mock currency scraper functiom
+# class TestCreateDimCurrency:
+#     @patch("src.dataframes.scrape_currency_names")  
+#     def test_dim_currency_returns_columns_and_values(self):
+#         d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"]}
+#         test_df = {"currency": pd.DataFrame(data=d)}
+#         result = create_dim_currency(test_df)
+#         expected_d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"], "currency_name": ["US Dollar", "Euro", "Pound"]}
+#         expected_df = pd.DataFrame(data=expected_d)
+#         expected_result = expected_df.copy()
+#         assert result.equals(expected_result)  
+
+#     def test_dim_currency_returns_dataframe(self):
+#         d = {"currency_id": [1, 2, 3], "currency_code": ["USD", "EUR", "GBP"]}
+#         test_df = {"currency": pd.DataFrame(data=d)}
+#         result = create_dim_currency(test_df)
+#         assert isinstance(result, pd.DataFrame)  
+        
+    
 
     
\ No newline at end of file